Repository navigation
listing: open private projects from Pascal with no secret in the viewer - #2
Merged
Merged
Conversation
The listing viewer now takes access from Pascal's handoff. When Pascal sends a visitor (Open in <viewer>, or a private link bound to this viewer), the viewer starts an authorization-code + PKCE round trip, exchanges the code for a short-lived credential for that one project, keeps it in this tab's sessionStorage and renews it near expiry. Public visits stay anonymous and skip the registry lookup. The same deployed bundle works for every project its owner binds. - src/pascal/handoff.ts + access.ts: entry detection, descriptor lookup, S256 PKCE, immediate callback scrubbing, state and issuer checks, cookie-free exchange, renewal with a loop guard, and a reopen state instead of any silent fallback after a credential failure - the company token endpoint (VITE_PASCAL_TOKEN_URL) still wins when set - AGENTS.md "Open from Pascal"; 16 new smoke scenarios Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listing template can now open private Pascal projects with no secret in the viewer. It is the client side of pascalorg/private-editor#1556.
src/pascal/handoff.ts: authorization code plus S256 PKCE. The verifier lives in sessionStorage, the callback parameters are scrubbed from the URL, and the code is exchanged for a short-lived origin-bound credential.src/pascal/access.ts: decides whether a visit involves the handoff, and runs the reopen flows ("Reopen your share link", "Open again from Pascal") when the credential expires or is revoked. Plain public visits skip the descriptor lookup entirely.Depends on #1556 being deployed before it works against editor.pascal.app. Public projects behave as before.
🤖 Generated with Claude Code